Improve the Aspire VS Code extension funnel by adamint · Pull Request #17898 · microsoft/aspire

adamint · 2026-06-04T03:22:52Z

Description

Improve the VS Code extension path for users who open an Aspire app in VS Code.

The Marketplace README now shows the AppHost discovery -> run/debug -> dashboard workflow with focused TypeScript AppHost screenshots. The extension also emits bounded telemetry for the first-run funnel so we can see where users drop off:

activation with workspace shape
CLI availability checks for command and debug gates
AppHost discovery source, result, duration, language bucket, and candidate counts
AppHost launch request/result, mode, command, language bucket, and non-sensitive error kind
running AppHosts view state, errors, resource counts, and workspace candidate counts

All new telemetry values are coarse enums/counts. Paths, command output, error messages, and user content are not emitted.

User-facing usage

Users can open an Aspire repo in VS Code, run Aspire: Configure launch.json file, press F5, then use the Aspire view and dashboard while the app runs. The Marketplace page now shows that flow directly.

Screenshot evidence

These are real captures from this branch. The VS Code and dashboard shots now come from the same clean C# + Node Aspire E2E workspace using the repo-built Aspire CLI. The debug shot is paused on a real breakpoint I set in Program.cs; the call stack shows the AppHost, C# worker, and Node debug sessions attached.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

Validation

./build.sh from extension/ (Build completed successfully!)
corepack yarn run compile-tests && corepack yarn run lint
corepack yarn run unit-test -- --config .vscode-test-pr17898.mjs with a short VS Code user-data path (966 passing, 1 pending)
PR tester proof lane: VSIX build, packageSurface E2E (7/7), and appHostTree E2E (4/4)
Focused PR Improve the Aspire VS Code extension funnel #17898 debugger evidence E2E: ASPIRE_EXTENSION_E2E_SHARD=pr17898-debugger-evidence ... corepack yarn run test:e2e (1/1, captures AppHost view, dashboard, and real breakpoint from the same C# + Node project)
Latest upstream/main merged into this branch
4-lane automated review panel: architecture/simplicity, edge/regression, Aspire domain review, and PR tester proof

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-06-04T03:23:02Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17898

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17898"

Copilot

Pull request overview

This PR improves the Aspire VS Code extension’s first-run “happy path” funnel by (1) updating the Marketplace README to clearly show AppHost discovery → run/debug → dashboard, and (2) adding new bounded, coarse-grained telemetry events to understand where users drop off (activation/workspace shape, CLI gate checks, AppHost discovery/launch, and running AppHosts view state).

Changes:

Add new telemetry event catalog entries for activation, CLI availability checks, AppHost discovery results, AppHost launch requested/result, and additional running AppHosts view signals.
Emit the new telemetry from activation, CLI gating, AppHost discovery, AppHost launch, and the running AppHosts view.
Update extension README with an animated walkthrough and focused screenshots aligned to the intended user flow.

Show a summary per file

File	Description
extension/telemetry.json	Registers new telemetry event/property classifications for the funnel stages.
extension/src/views/AppHostsViewTelemetry.ts	Adds workspace AppHost state/error/candidate-count signals when the view is shown.
extension/src/utils/workspace.ts	Adds telemetry for CLI availability checks (gate operation + duration).
extension/src/utils/telemetryRegistry.ts	Extends the typed telemetry schema for the new events/properties/measurements.
extension/src/utils/appHostDiscovery.ts	Emits discovery result telemetry (source/outcome/duration/candidate counts/language summary).
extension/src/services/AppHostLaunchService.ts	Emits launch requested/result telemetry (mode/command/language/outcome/error kind + duration).
extension/src/extension.ts	Emits activation telemetry and plumbs CLI-gate operation labels.
extension/src/debugger/AspireDebugConfigurationProvider.ts	Labels the debug-time CLI availability gate for telemetry.
extension/README.md	Updates Marketplace-facing docs with the “happy path” walkthrough and screenshots.

Copilot's findings

Files reviewed: 9/12 changed files
Comments generated: 1

github-actions · 2026-06-04T04:23:25Z

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Hosting-5 / Hosting-5 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adamint

Reviewed with four dedicated passes. I did not find any new, non-duplicate high-confidence issues to raise.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

davidfowl · 2026-06-06T01:13:54Z

Screenshots need more TypeScript, too much C# in here.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adamint · 2026-06-11T20:11:46Z

Updated the README examples and screenshots/walkthrough to use the TypeScript starter and apphost.mts, including the dashboard/resources view.

Copilot

Copilot's findings

Files reviewed: 11/15 changed files
Comments generated: 0 new

Copilot

Copilot's findings

Files reviewed: 11/15 changed files
Comments generated: 1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Treat VS Code debug launch cancellation separately from launch errors so telemetry and tree-view error UI do not count provider-cancelled launches as failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 16/20 changed files
Comments generated: 0 new

Replace the weak README animation with a compact static storyboard, use packaged README media paths so PR and marketplace rendering are reliable, and keep launch failures visible when VS Code declines to start an Aspire debug session. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove branch-specific workspace names and temporary paths from the README screenshots so the Marketplace visuals show the intended generic Aspire workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 16/20 changed files
Comments generated: 0 new

Remove the happy-path storyboard image and update the debug-session screenshot so it clearly shows an AppHost paused at a breakpoint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 16/19 changed files
Comments generated: 1

github-actions · 2026-06-20T04:36:25Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Replace the README screenshots with real cropped VS Code captures and address Copilot review feedback by reusing shared telemetry error classification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 18/21 changed files
Comments generated: 0 new

github-actions · 2026-06-20T19:31:38Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

adamint · 2026-06-20T19:40:40Z

(automated comment)

Post-fix pass on the latest head b10ba7dad097ceaf32c465c6dcdb533befa730e5.

Review feedback checked:

Screenshot feedback had already been addressed with TypeScript AppHost screenshots and README updates.
Prior inline comments for telemetry fs.stat, duplicate launch error classification, and unused imports are addressed; the two remaining unresolved outdated threads are now resolved.
The review panel found one additional coverage gap for runningapphostsview/shown; fixed by adding appHostsViewTelemetry.test.ts for all workspace AppHost state buckets.

Validation:

./build.sh from extension/ passed.
corepack yarn run compile-tests && corepack yarn run lint passed.
corepack yarn run unit-test -- --config .vscode-test-pr17898.mjs with a short VS Code user-data path: 966 passing, 1 pending.
PR tester proof: VSIX built, packageSurface E2E 7/7, appHostTree E2E 4/4.
Screenshots are linked in the PR description from branch resources; no new video was needed because the changed proof is telemetry/test/E2E-log based.

Final review orchestration lanes:

Architecture/simplicity: claude-opus-4.8, high — no must-fix issues.
Edge cases/regressions: gpt-5.5, high — no high-confidence regressions.
Aspire domain code review: claude-opus-4.8, high — no high-confidence issues after the new telemetry-view test.
PR tester proof: gpt-5.5, high — pass, with the proof above.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adamint · 2026-06-20T21:48:06Z

(automated comment)

Updated the screenshot evidence from one C# + Node Aspire project:

The debugger shot is a real breakpoint hit in Program.cs with AppHost, C# worker, and Node debug sessions attached. Validation: focused E2E proof passed, 1/1.

Improve Aspire VS Code extension funnel

d5a67c2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 03:22

Copilot started reviewing on behalf of adamint June 4, 2026 03:23 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread extension/src/services/AppHostLaunchService.ts

Keep launch telemetry best-effort

66b6563

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions Bot mentioned this pull request Jun 4, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

adamint marked this pull request as draft June 4, 2026 21:21

adamint added the area-vscode-extension label Jun 4, 2026

adamint self-assigned this Jun 4, 2026

adamint commented Jun 4, 2026

View reviewed changes

adamint and others added 2 commits June 4, 2026 22:51

Update VS Code extension README assets

18a7f6e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix AppHost discovery tests on Windows

c13f879

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adamint marked this pull request as ready for review June 5, 2026 18:40

adamint commented Jun 5, 2026

View reviewed changes

Comment thread extension/README.md Outdated

adamint and others added 3 commits June 5, 2026 14:46

Apply suggestion from @adamint

e33c5ed

Fix VS Code extension README link text

4c37ce8

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge main into vscode extension growth

cb130c0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adamint marked this pull request as draft June 11, 2026 18:57

Update VS Code extension funnel screenshots

f332fdf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 11, 2026 20:11

adamint marked this pull request as ready for review June 11, 2026 20:11

adamint requested a review from davidfowl June 11, 2026 20:11

Copilot started reviewing on behalf of adamint June 11, 2026 20:12 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

adamint marked this pull request as draft June 12, 2026 16:21

adamint marked this pull request as ready for review June 12, 2026 17:45

Copilot started reviewing on behalf of adamint June 18, 2026 00:55 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread extension/src/services/AppHostLaunchService.ts Outdated

adamint marked this pull request as draft June 18, 2026 02:28

adamint and others added 2 commits June 17, 2026 22:40

Harden VS Code telemetry dimensions

45a5f7b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix canceled AppHost launch telemetry

c6a56c8

Treat VS Code debug launch cancellation separately from launch errors so telemetry and tree-view error UI do not count provider-cancelled launches as failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 18, 2026 21:16

Copilot started reviewing on behalf of adamint June 18, 2026 21:17 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

adamint marked this pull request as ready for review June 20, 2026 03:56

Copilot AI review requested due to automatic review settings June 20, 2026 03:56

Copilot started reviewing on behalf of adamint June 20, 2026 03:56 View session

adamint and others added 2 commits June 19, 2026 23:58

Merge upstream main into VS Code funnel PR

4254d2e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Polish VS Code extension README screenshots

8d12f64

Remove branch-specific workspace names and temporary paths from the README screenshots so the Marketplace visuals show the intended generic Aspire workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Jun 20, 2026

View reviewed changes

Refine VS Code extension README visuals

9b37e2e

Remove the happy-path storyboard image and update the debug-session screenshot so it clearly shows an AppHost paused at a breakpoint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 20, 2026 04:04

Copilot started reviewing on behalf of adamint June 20, 2026 04:05 View session

Copilot AI reviewed Jun 20, 2026

View reviewed changes

Comment thread extension/src/extension.ts Outdated

adamint and others added 3 commits June 20, 2026 00:39

Improve extension README visuals

cea1935

Replace the README screenshots with real cropped VS Code captures and address Copilot review feedback by reusing shared telemetry error classification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main' into pr-17898-review-fixes

9eabd90

Add AppHosts view telemetry tests

b10ba7d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 20, 2026 19:05

Copilot started reviewing on behalf of adamint June 20, 2026 19:06 View session

Copilot AI reviewed Jun 20, 2026

View reviewed changes

Update VS Code extension screenshot evidence

9f0862e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Conversation

adamint commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing usage

Screenshot evidence

Checklist

Validation

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

adamint left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidfowl commented Jun 6, 2026

Uh oh!

adamint commented Jun 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

github-actions Bot commented Jun 20, 2026

Uh oh!

adamint commented Jun 20, 2026

Uh oh!

adamint commented Jun 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adamint commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 4, 2026 •

edited

Loading